QTimer::setInterval expects int argument #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems pretty harmless for Noetic still... Am I correct? |
|
Hi Bence, |
|
I don't think the test failure is linked to my change. |
|
agreed, I'll re-run them, I think it's only flakiness |
Since Ubuntu 22.04 / Qt 5.15, Qt is pickier about the correct type.
This package is not very critical and it is unclear what it should do at all when testing is disabled. But as the CMakeLists.txt requires these packages during either build, they are NOT just test dependencies. Required to make use of added functions to exclude test depends in builds ros-infrastructure/bloom#649
v4hn
added a commit
to v4hn/ros-o-builder
that referenced
this pull request
Oct 12, 2024
until ros-controls/ros_control#519 is merged.
bmagyar
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Ubuntu 22.04 / Qt 5.15, Qt seems to be pickier about the correct type, and loading the rqt plugin fails.
https://doc.qt.io/qt-5/qtimer.html#interval-prop